Skip to content

Conversation

@nikagra
Copy link

@nikagra nikagra commented Nov 6, 2025

Addressing #755, which is a corner case of work done as part of #597.

Changes:

  • Accounting for possibility of a null value of resultMetadataId, using empty byte array instead in Exectute message.
  • Implementing unit tests to cover the case

@dkropachev
Copy link

Looks like majority of tests are failed due to the bug in testing framework

@dkropachev
Copy link

Something is off, i rerun pipeline on scylla-3.x and it did not have this issue - https://github.com/scylladb/java-driver/actions/runs/19147584619

@nikagra nikagra changed the title Handling empty resultMetadataId in Execute message 3.x: Handle empty metadataid when metadataid feature is on Nov 7, 2025
@nikagra nikagra force-pushed the 3.x_empty_resultMetadataId_fix branch 2 times, most recently from b019cbc to 0f3ae37 Compare November 12, 2025 11:36
@nikagra nikagra force-pushed the 3.x_empty_resultMetadataId_fix branch from 0f3ae37 to 163c6ac Compare November 12, 2025 13:19
@dkropachev dkropachev merged commit fb67bf5 into scylladb:scylla-3.x Nov 12, 2025
11 checks passed
@nikagra nikagra deleted the 3.x_empty_resultMetadataId_fix branch November 12, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants